feat(browser): Mark errors caught in wrap as unhandled#8898
Closed
feat(browser): Mark errors caught in wrap as unhandled#8898
wrap as unhandled#8898Conversation
Contributor
size-limit report 📦
|
Lms24
changed the title
wrap as unhandledwrap as unhandled
3 tasks
AbhiPrasad
approved these changes
Aug 30, 2023
Member
Author
|
closing in favour of #8927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs adjusting the exception mechanism's
handledvalue.For more details see #8890
Changed Instrumentation
This PR addresses setting the mechanism in the browser package API
wrap. I previously didn't know this existed but you live and learn 😅. Decided to keep #8890 atomic and open a separate PR, should we need to revert the changes there.Note: we should improve the typing of
wrap- opened #8897 to trackref #6073